[vlc-devel] [PATCH] Fix DRM DR VAAPI use case

[Thomas Guillem]

Hello,

On Tue, Sep 5, 2017, at 01:37, Mathieu Velten wrote:
> - missing break
> - close is already handled in the error case of fct tc_vaegl_init
> ---
>  modules/video_output/opengl/converter_vaapi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/video_output/opengl/converter_vaapi.c
> b/modules/video_output/opengl/converter_vaapi.c
> index 6ffee98fb5..9eda54ba7c 100644
> --- a/modules/video_output/opengl/converter_vaapi.c
> +++ b/modules/video_output/opengl/converter_vaapi.c
> @@ -422,9 +422,9 @@ Open(vlc_object_t *obj)
>          {
>              ret = tc_vaegl_init(tc, dpy, (VANativeDisplay) (intptr_t)
>              drm_fd,
>                                  drm_native_destroy_cb);
> +            if (ret == VLC_SUCCESS)
> +                break;

OK with this block.

>          }
> -        else
> -            vlc_close(drm_fd);

This vlc_close is called when dpy is NULL, so when tc_vaegl_init is not
called, si it's still needed

>      }
>  #endif
>  
> -- 
> 2.13.5
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel