[vlc-devel] [PATCH 2/5] input: extends navigation control

[Thomas Guillem]

On Mon, Sep 4, 2017, at 17:53, Rémi Denis-Courmont wrote:
> Le maanantaina 4. syyskuuta 2017, 12.33.02 EEST Thomas Guillem a écrit :
> > Add ControlNav() function. It moves the viewpoint if the input is not a
> > menu. ---
> >  src/input/input.c | 66
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 64
> > insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/input/input.c b/src/input/input.c
> > index 49653db76f..f02557370f 100644
> > --- a/src/input/input.c
> > +++ b/src/input/input.c
> > @@ -1763,6 +1763,69 @@ static void ViewpointApply( input_thread_t *p_input )
> > }
> >  }
> > 
> > +static void ControlNav( input_thread_t *p_input, int i_type )
> > +{
> > +    input_thread_private_t *priv = input_priv(p_input);
> > +
> > +    /* Handle navigation if input has title */
> > +    if( priv->master->i_title > 0 )
> 
> This looks excessive. I expect that sooner or later, we will have wide
> angle 
> tracks in navigable media.
> 
> IMO you should rather send the control blindly to the master demux  and 
> perform fallback actions in case of failure.

Ah yes, that what we discussed about. I'll do that instead.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel