[vlc-devel] [PATCH] avcodec: map our debug level to the ffmpeg debug level

[Rémi Denis-Courmont]

Le torstaina 31. elokuuta 2017, 8.45.21 EEST Steve Lhomme a écrit :
> otherwise we don't even get debug messages at all
> ---
>  modules/codec/avcodec/avcommon.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/modules/codec/avcodec/avcommon.h
> b/modules/codec/avcodec/avcommon.h index 5b8deb19aa..24e4e997e2 100644
> --- a/modules/codec/avcodec/avcommon.h
> +++ b/modules/codec/avcodec/avcommon.h
> @@ -74,6 +74,9 @@ static inline void vlc_init_avutil(vlc_object_t *obj)
>              break;
>          case VLC_MSG_DBG:
>              level = AV_LOG_VERBOSE;
> +            break;
> +        case VLC_MSG_DBG+1:
> +            level = AV_LOG_DEBUG;

There is no VLC_MSG_DBG + 1 level. The description does not match what you´re 
actually doing here: adding a more verbose than debug level that only affects 
Libavutil.

And that´s a rather ugly way to go about it, IMO. A plugin option to turn on 
libavutil debug would make more sense if it´s really needed.

>          default:
>              break;
>          }

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/