[vlc-devel] [vlc-commits] contribs: Ensure we're using the contrib libraries when available

[Hugo Beauzée-Luyssen]

On Mon, Sep 18, 2017, at 05:02 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 18. syyskuuta 2017, 8.27.06 EEST Hugo Beauzée-Luyssen a
> écrit :
> > vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Fri Sep 15
> > 17:36:54 2017 +0200| [8c37ebde339a92b8043652c7eabe52836f2a1d87] |
> > committer: Hugo Beauzée-Luyssen
> > 
> > contribs: Ensure we're using the contrib libraries when available
> 
> What? Obviously, that was already done from the beginning, otherwise 
> dependencies would never have worked.
> 
> This patch does only two things: break support for external LDFLAGS, who
> no 
> longer have precedence, and introrduce an inconsistency with CFLAGS
> handling.
> 

I agree with the inconsistency with the CFLAGS, although reverting this
means the macOS builds will start failing again, so I suppose the global
LDFLAGS are filled with invalid values before contribs flags are added.
I'd rather fix that before reverting

> Please revert.
> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr