[vlc-devel] Reviews (was Re: [PATCH 1/4] es: move i_profile/i_level to audio and video format structs)

Jean-Baptiste Kempf jb at videolan.org
Tue Apr 3 22:35:59 CEST 2018

On Tue, 3 Apr 2018, at 11:39, RĂ©mi Denis-Courmont wrote:
> If you cannot criticize patches in public, you cannot do a honest code review. 

Noone is refusing you the right to criticize in public.

What we object to is your reviews that noone seems to understand, except you. (Or maybe Filip, but he's gone.)
And we have again 3 examples, in the last 3 days. And each time it explodes, for absolutely no reason.

Yes, "violation of the  memory model" is not a review that most people can act upon.
Same for "violation of the spec", or "this makes no sense", "this is non-sensical", or the "this is impossible" or "this is wrong" reviews, while it was already more-or-less working in VLC.
Maybe that seems normal to you, but no, it is not. And don't give me the usual that "there is no other way to express the issue". This is not true.

Seriously, put yourself in the shoes of people who try to contribute. When you started coding on VLC, you did not know all of those things, and that is normal.

Of course, you are going to disagree and get upset at reading this email, but VLC is popular because it is pragmatic (and not adhering to every spec), and because we have a vibrant community, (and probably one of the most fun ones), even if it is far from perfect. Because we are the ones with the conehats, and the ones that go to theme parks, go to Hawaii, because we brew beer and chocolate. Also, because we work on stupid extensions (HTCPCP, RDP orKaraoke!).
This is not the Linux kernel or a networking stack: this is the VLC! The cone player, that people love.

The worse is that you are getting upset a lot, because the discussion goes on and on, and instead of explaining simply what is wrong quickly, this is a loss of your time (which is probably more precious than mine) and everyone else. So, in the end, the small gain of time is a net loss...
Then, more upset, then ulcer. Bad idea.

As we are on the topic of reviews, if one old developer-and-active post a quick patch to have an opinion, there is no need to review the leaks, especially in the error cases. We know. If we ask, and not push directly, it is because we want an opinion on the way, not for the small details.

Seriously, you are not a bad person, a contrario from persons that are not in this project anymore, or people that were in some other multimedia open source projects. If you were, I would have kicked you a long time ago. So this is all a communication issue.

So everyone, chill out, smoke some weed, take a deep breath, drink some whisky (or hot chocolate), and calm down.
And please try to put yourselves in other people shoes.


PS: I will now close this mailing list for at least a day, for everyone to calm down.

PPS: or Hugo, for C++++17,20,23 or 32 :D
Jean-Baptiste Kempf -  President
+33 672 704 734

Jean-Baptiste Kempf -  President
+33 672 704 734

More information about the vlc-devel mailing list