[vlc-devel] [PATCH 1/6] os2: implement vlc_once()

KO Myung-Hun komh78 at gmail.com
Wed Apr 4 16:08:10 CEST 2018



Rémi Denis-Courmont wrote:
> Le mardi 3 avril 2018, 15:48:23 EEST Kamil Rytarowski a écrit :
>> On 03.04.2018 13:52, Rémi Denis-Courmont wrote:
>>> I gave you the benefits of doubt, but now you are obviously trolling.
>>
>> So given that the only argument rejecting the patch is ad personam
> 
> No, the argument for rejecting the original patch and the NetBSD-derived one 
> is that they are invalid as demonstrated in my previous post - but it should 
> be obvious to anybody who understands _and_ acknowledges either the ISO C11 or 
> POSIX.2008 threading/memory rules.
> 

Do you mean that sharing non-atomic variable among threads without any
memory order or locking is the violation of memory model ?

In general, the violation of memory model may lead to undefined
behavior, but this is not the case.

BTW, you did reject to review both the second patch and the third patch
using the atomic operations. Why ? They do not violate the memory model.

> As for the ones with atomic ops are most certainly more intricate than they 
> need be. If somebody else is capable, willing and available to review them, s/
> he is most welcome. They are not getting merged without a proper review 
> though.
> 

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/



More information about the vlc-devel mailing list