[vlc-devel] [vlc-commits] VLSub: Convert path to current codepage

[Rémi Denis-Courmont]

Le 5 avril 2018 14:11:11 GMT+03:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>On Thu, Apr 5, 2018, at 12:55 PM, Rémi Denis-Courmont wrote:
>> This will break very badly if the path contains non-ANSI characters, 
>> which is qcommon for exactly the foreign languages content where you 
>> need subtitles.
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser 
>> ma brièveté.
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>Hi,
>
>lua's io.open uses fopen, which IIUC interprets the given path as ANSI,
>so I'm not sure if we can do something better (beside patching/forking
>lua to use unicode, which I'm "a bit" reluctant to do)
>
>-- 
>  Hugo Beauzée-Luyssen
>  hugo at beauzee.fr
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Eh, I don't care if you don't fix it. I don't use VLsub and I don't use VLC on Windows. But every single time so far that we have restricted file paths to ANSI, users complained eventually. I won't be dealing with the ensuing support issues.

Also adding a Lua function that is then known broken by design is highly questionable.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.