[vlc-devel] [PATCH 2/4] aout: keep the requested aout-mode across several inputs

[Thomas Guillem]

On Thu, Apr 5, 2018, at 18:17, Rémi Denis-Courmont wrote:
> Le torstaina 5. huhtikuuta 2018, 19.05.57 EEST Thomas Guillem a écrit :
> > On Thu, Apr 5, 2018, at 17:57, Rémi Denis-Courmont wrote:
> > > Le torstaina 5. huhtikuuta 2018, 18.54.33 EEST Thomas Guillem a écrit :
> > > > On Tue, Apr 3, 2018, at 09:33, Rémi Denis-Courmont wrote:
> > > > > But it breaks existing stereo mode in the normal case, whereby it must
> > > > > not be preserved.
> > > > 
> > > > I don't see how it breaks the existing stereo-mode.
> > > 
> > > This specific patch "only" breaks backward compatibility with the existing
> > > configuration and CLI. It's the later patch that finish breaking it.
> > 
> > Could tell me the step to reproduce the breakage ? I really don't get it
> > (Yes, I tried to reproduce it again by touching the aout/stereo-mode via
> > cli).
> 
> What? Again?
> How do you define "reverse stereo" or dual-mono modes with a surround track? 
> They make literally no sense there, AFAICT. It's pretty damn obvious from the 
> code and from semantics that the existing stuff is specific to stereo tracks.

We just don't show the "reverse stereo" or dual-mono modes in case of surround. And if this mode is preferred by the user, we just ignore it for the current input.

> 
> Likewise, how do you define surround PCM and surround pass-through modes 
> (however you call them) with a stereo track?

Likewise, we don't show these options with a stereo track.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel