[vlc-devel] [PATCH] Use #include <config.h> instead of "config.h"

Steve Lhomme robux4 at ycbcr.xyz
Fri Apr 6 09:02:35 CEST 2018


My understanding of the <> vs "" has always been this one 
https://stackoverflow.com/a/3162067/1266123

If you use <> it will look in system headers first. Fix for a local 
config is not what we want. It's unlikely there is a config.h in system 
header but it's still a waste of time to look in there.

I don't know why autotools people think it's a good practice. And if 
there's a local config.h then it's on purpose so there's still no use to 
make <> a general case. It's only good for installed headers.


Le 05/04/2018 à 20:17, Marvin Scholz a écrit :
> Does anyone has an opinion about this?
>
> On 28 Mar 2018, at 16:50, Marvin Scholz wrote:
>
>> This follows the recomendation in the autoconf documentation, which
>> states:
>>
>>> With the appropriate -I option, you can use ‘#include <config.h>’.
>>> Actually, it's a good habit to use it, because in the rare case
>>> when the source directory contains another config.h, the build
>>> directory should be searched first.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list