[vlc-devel] [PATCH] input: don't send ES_OUT_ *PCR/SET_NEXT_DISPLAY_TIME from slaves

Thomas Guillem thomas at gllm.fr
Mon Apr 9 11:43:51 CEST 2018


On Mon, Apr 9, 2018, at 10:09, Rémi Denis-Courmont wrote:
> Le 9 avril 2018 09:27:00 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
> >
> >On Mon, Apr 9, 2018, at 05:21, Francois Cartegnie wrote:
> >> Le 05/04/2018 à 18:04, Thomas Guillem a écrit :
> >> > This avoid having slaves messing up the timing of the main input.
> >> > 
> >> > Fixes #19689
> >> 
> >> The fix isn't about not setting the PCR, but aiming a dedicated
> >clock.
> >> That's part of es_out redesign.
> >
> >We can backport it just for 3.0 in order to fix #19689 and have a
> >proper fix later for 4.0.
> >
> >> 
> >> -- 
> >> Francois Cartegnie
> >> VideoLAN - VLC Developer
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
> 
> You cannot be serious. 3.0 is a _*stable*_ branch.

I'm very serious, I did this patch, I'm aware of possible repercussions. Before merging, I plan to test every demuxers as a slave that use the ES_OUT_SET_NEXT_DISPLAY_TIME command. There are not many, I guess the most important one to test is when demuxing a subtitle via avformat.



> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list