[vlc-devel] [PATCH] mmdevice: use IAudioStreamVolume to change volume

[Thomas Guillem]

On Mon, Apr 9, 2018, at 12:37, Rémi Denis-Courmont wrote:
> Le 9 avril 2018 11:23:01 GMT+03:00, Jean-Baptiste Kempf 
> <jb at videolan.org> a écrit :
> >Hello,
> >
> >On Mon, 9 Apr 2018, at 10:13, Rémi Denis-Courmont wrote:
> >> We of course already considered that. It obviously leads to
> >saturation 
> >> basically all the time on properly mixed streams.
> >
> >As most of the output are in float, are you sure about that?
> >
> >Best,
> >
> >-- 
> >Jean-Baptiste Kempf -  President
> >+33 672 704 734
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
> 
> Oh I am sure it will work by accident for some cases and fail miserably 
> in others. I don't know all the WASAPI backends and filters. As it is a 
> plugable system, nobody knows.
> 
> The only thing I know for sure is that:
> - it will utterly fail when integer format is used,

Indeed. We could force FL32 output for integers inputs but I'm afraid of possible precision loss (specially for S24/S32).

> - audio will eventually be integer, as DACs cannot do float.

Yes but this won't change anything, the float -> integer conversion will be done at the end after processing all filters, no ?


> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel