[vlc-devel] [vlc-commits] picture: round the number of visible lines to the upper multiple

[Steve Lhomme]

Le 16/04/2018 à 18:32, Rémi Denis-Courmont a écrit :
> Le maanantaina 16. huhtikuuta 2018, 19.25.54 EEST Steve Lhomme a écrit :
>> Le 16/04/2018 à 17:09, Rémi Denis-Courmont a écrit :
>>> Le maanantaina 16. huhtikuuta 2018, 17.56.34 EEST Tristan Matthews a écrit
> :
>>>> On Mon, Apr 16, 2018 at 10:38 AM, Steve Lhomme <git at videolan.org> wrote:
>>>>> vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Mon Apr 16
>>>>> 15:35:23 2018 +0200| [82f649983443292bd893962cac0484b7df8d1c89] |
>>>>> committer: Steve Lhomme
>>>>>
>>>>> picture: round the number of visible lines to the upper multiple
>>>> This breaks make check for me:
>>> Same here.
>>>
>>> On which platform was the test suite run before submitting for review?
>> For the n-th time: make check doesn't work on Windows.
> So what?
>
> Passing the test suite on a platform is not optional.

If you mean submitted code should pass the test suite, yes I agree 
(unless the test is wrong, of course).

If you mean all platform should pass the test suite then it's been 
optional forever.

>
> | I can't believe we are having the argument of "Test that your patches
> | actually work"...
> -- Greg Kroah-Hartmann.
>