[vlc-devel] [PATCH] vout: fix fullscreen race condition

[Rémi Denis-Courmont]

Le tiistaina 17. huhtikuuta 2018, 19.50.33 EEST Romain Vimont a écrit :
> > > The fact that the Qt GUI reveals it is just a consequence.
> > 
> > No, the Qt GUI is just buggy.
> 
> What do you think about this alternate patch:

The FSC makes the incorrect assumption that there is only one fullscreen flag. 
This hack just moves the problem.

> diff --git a/modules/gui/qt/components/controller.cpp
> b/modules/gui/qt/components/controller.cpp index e10b1e4208..3b4e3bbd66
> 100644
> --- a/modules/gui/qt/components/controller.cpp
> +++ b/modules/gui/qt/components/controller.cpp
> @@ -1209,9 +1209,7 @@ void FullscreenControllerWidget::setVoutList(
> vout_thread_t **pp_vout, int i_vou vout.append( p_vout );
>          var_AddCallback( p_vout, "fullscreen",
>                           FullscreenControllerWidget::FullscreenChanged,
> this ); -        /* I miss a add and fire */
> -        emit fullscreenChanged( p_vout, var_InheritBool( THEPL,
> "fullscreen" ), -                           var_GetInteger( p_vout,
> "mouse-hide-timeout" ) ); +        var_SetBool( p_vout, "fullscreen",
> var_InheritBool( THEPL, "fullscreen" ) ); vlc_mutex_unlock( &lock );
>      }
>  }

-- 
Реми Дёни-Курмон
http://www.remlab.net/