[vlc-devel] [PATCH v2] vout: fix fullscreen race condition

[Rémi Denis-Courmont]

Le 18 avril 2018 11:44:36 GMT+03:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>On Wed, Apr 18, 2018 at 11:29:57AM +0300, Rémi Denis-Courmont wrote:
>> Again, Qt has no business mucking core variables there and then. What
>if Qt is not enabled? What if other UIs do something similar at the
>same time?
>
>I agree with this, that's why I first posted a Qt-independant patch,
>that you rejected (with good arguments).
>
>This is just a workaround to avoid the race condition leading to bug
>#19697.
>
>What do you suggest, instead?
>
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté.
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Do you want to show the FSC on non-embedded video windows?

If yes, you have to deal with the fact that there may be simultaneously fullscreen and non-fullscreen windows. As such tracking a single global fullscreen state will never work properly, because there is no such thing.

If no, you can simply track fullscreen state through the Qt video window. There are no needs to touch the fullscreen object variables at all.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.