[vlc-devel] [PATCH v3] qt: initialize FSC fullscreen state from the vout

Romain Vimont rom1v at videolabs.io
Wed Apr 18 14:38:30 CEST 2018

The playlist and vout "fullscreen" variables may contain different
values, e.g. when fullscreen is toggled during vout creation.

On vout list changes, initialize the FSC fullscreen state from the vout,
so that the FSC state is consistent with the video state.

Fixes #19697
Patches v1 and v2 attempted to apply the playlist "fullscreen" state to
the vout once it was initialized, so that any fullscreen toggle missed
by the vout was "recovered".

Instead, this patch changes the FSC state so that it matches the vout
"fullscreen" state once it is initialized. That way, if a fullscreen
toggle is missed by the vout, it is "also missed" by the FSC, and both
stay consistent.

 modules/gui/qt/components/controller.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/qt/components/controller.cpp b/modules/gui/qt/components/controller.cpp
index e10b1e4208..5f2d1efa49 100644
--- a/modules/gui/qt/components/controller.cpp
+++ b/modules/gui/qt/components/controller.cpp
@@ -1210,7 +1210,7 @@ void FullscreenControllerWidget::setVoutList( vout_thread_t **pp_vout, int i_vou
         var_AddCallback( p_vout, "fullscreen",
                          FullscreenControllerWidget::FullscreenChanged, this );
         /* I miss a add and fire */
-        emit fullscreenChanged( p_vout, var_InheritBool( THEPL, "fullscreen" ),
+        emit fullscreenChanged( p_vout, var_InheritBool( p_vout, "fullscreen" ),
                            var_GetInteger( p_vout, "mouse-hide-timeout" ) );
         vlc_mutex_unlock( &lock );

More information about the vlc-devel mailing list