[vlc-devel] [PATCH] prefetch: remove read size, always request maximum

Thomas Guillem thomas at gllm.fr
Fri Apr 20 13:47:25 CEST 2018

I'm afraid this commit is quite dangerous.

I'm working on the libsmb2 access now and got this error with this prefetch commit:

[00007f54d4000d90] smb2 access error: smb2_read_async failed: Read count 16777216 larger than max_read_size 8388608

It's OK, I can fix this particular access, but what about other modules ?

Should all accesses handle such huge read sizes ? It can be set to 1GB from settings. A lot of access plugins will just do a malloc of 1GB then...

On Wed, Apr 18, 2018, at 10:51, Rémi Denis-Courmont wrote:
> And? Care to explain how prefetch is not doing the same thing than the 
> UDP thread?
> Also, DTV is totally broken for me in 3.0, even though it does not use 
> prefetch at all. And that is leaving aside the 4.0-only infinite loop in 
> cache_block.
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list