[vlc-devel] [vlc-commits] videotoolbox: always abort in case of BadDataErr

[Rémi Denis-Courmont]

Le 20 avril 2018 18:29:49 GMT+03:00, Thomas Guillem <git at videolan.org> a écrit :
>vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Apr 20
>17:17:19 2018 +0200| [2af423e59496b52267949b0e77a692a844bc5c38] |
>committer: Thomas Guillem
>
>videotoolbox: always abort in case of BadDataErr
>
>It's safer to fallback to SW dec the earliest possible since the stream
>is
>likely to contain more problematic data.
>
>>
>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2af423e59496b52267949b0e77a692a844bc5c38
>---
>
> modules/codec/videotoolbox.m | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/modules/codec/videotoolbox.m
>b/modules/codec/videotoolbox.m
>index 04e57dfe39..37f64ac9d0 100644
>--- a/modules/codec/videotoolbox.m
>+++ b/modules/codec/videotoolbox.m
>@@ -1773,11 +1773,11 @@ static int HandleVTStatus(decoder_t *p_dec,
>OSStatus status,
>                 break;
>             case -8960 /* codecErr */:
>             case kVTVideoDecoderMalfunctionErr:
>-            case -8969 /* codecBadDataErr */:
>-            case kVTVideoDecoderBadDataErr:
>             case kVTInvalidSessionErr:
>                 *p_vtsession_status = VTSESSION_STATUS_RESTART;
>                 break;
>+            case -8969 /* codecBadDataErr */:
>+            case kVTVideoDecoderBadDataErr:
>             default:
>                 *p_vtsession_status = VTSESSION_STATUS_ABORT;
>                 break;
>
>_______________________________________________
>vlc-commits mailing list
>vlc-commits at videolan.org
>https://mailman.videolan.org/listinfo/vlc-commits

This sort of makes sense for offline records. But fior live streams, bad data could very well be some transient problem.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.