[vlc-devel] [PATCH] Enable/Disable/Auto deinterlace functions for libvlc

[Luís Fernandes]

Hi Rémi,

Thanks for the input.

Currency, libvlc_video_set_deinterlace() will always select deinterlace 1 or 0, but I want to select -1 (Auto) as well.
Without changing the function signature of libvlc_video_set_deinterlace(), there’s no way to choose between, for example:
* 1 / blend
* -1 / linear

That’s why I’ve split into 2 different functions, so you can specify "-1" and then switch the deinterlacer-mode at will. I’ve also left the other one intact in order to not break ABI compatibility.

Can you help me choose what would you like me to implement in order to get this feature?
1 - break ABI compatibility and change the method signature to libvlc_video_set_deinterlace( libvlc_media_player_t *p_mi, int enabled, const char *psz_mode )
2 - not break ABI compatibility, and in order to implement the auto, change the "name" of the filter to be "auto-blend", "auto-bob", "auto-.." in order to signal that we want "-1" and not "1"
3 - not break ABI compatibility, and create a new function libvlc_video_set_deinterlace_filter( libvlc_media_player_t *p_mi, int enabled, const char *psz_mode ) but that would mean you would have 2 functions, one that supports -1 and the other that doesn’t.

Regards,
Luís

> On 21 Apr 2018, at 08:22, Rémi Denis-Courmont <remi at remlab.net> wrote:
> 
> Le vendredi 20 avril 2018, 23:29:06 EEST Luís Miguel Fernandes a écrit :
>> Hi,
>> 
>> In the current version of VLCKit is not possible to replicate the “Auto”
>> mode for deinterlace. This is a patch that will allow VLCKit to enable the
>> "auto" mode and specify which deinterlace filter to use.
>> 
>> This does not touch the existing deinterlace method in order to not break
>> compatibility, but instead adds two new functions that allows one to set
>> the deinterlace and deinterlace-mode separately.
> 
> I utterly fail to see why you need to add a new function; there is plenty of 
> entropy left to extend the existing function.
> 
> And adding two functions is not acceptable, as it cannot be made atomic ever.
> 
> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel