[vlc-devel] [PATCH 2/2] cache_block: restore stat calculation

Ilkka Ollakka ileoo at videolan.org
Sun Apr 22 11:18:02 CEST 2018


On Sat, Apr 21, 2018 at 07:45:27PM +0300, Rémi Denis-Courmont wrote:
> Le samedi 21 avril 2018, 12:44:23 EEST Ilkka Ollakka a écrit :
> > Seems that someone missed this stat, restore feature.

> > Was removed in 9a725a039d8cfcf91aabad0101da1563a627493f

> Because it's completely useless. The computed value is not even statistically 
> meaningful. In practice, we detect no data with prefill failure, and buffering 
> problem with too late warnings.

I agree that it was not serving that much purpose, but based on ticket
comment in bug report, for someone it had value.

I don't mind if this patch doesn't go in at all.

-- 
Ilkka Ollakka
"From there to here, from here to there, funny things are everywhere."
		-- Dr. Seuss
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180422/e5f7b0a7/attachment.sig>


More information about the vlc-devel mailing list