[vlc-devel] [PATCH 3/3] core: respect ODR for access_sys_t

Romain Vimont rom1v at videolabs.io
Mon Apr 23 11:33:58 CEST 2018


On Sun, Apr 22, 2018 at 07:36:17PM +0300, Rémi Denis-Courmont wrote:
> Le dimanche 22 avril 2018, 18:03:38 EEST Romain Vimont a écrit :
> > diff --git a/modules/services_discovery/upnp.cpp
> > b/modules/services_discovery/upnp.cpp index 863421141f..a3ff702087 100644
> > --- a/modules/services_discovery/upnp.cpp
> > +++ b/modules/services_discovery/upnp.cpp
> > @@ -87,12 +87,12 @@ struct services_discovery_sys_t
> >      UpnpInstanceWrapper* p_upnp;
> >      vlc_thread_t         thread;
> >  };
> > -} // namespace
> > 
> >  struct access_sys_t
> >  {
> >      UpnpInstanceWrapper* p_upnp;
> >  };
> > +} // namespace
> 
> Remove/Bypass access_sys_t competely here. And in any would-be similar case.
> 

OK, but I would like to avoid additional refactors in this specific
patch set.


More information about the vlc-devel mailing list