[vlc-devel] [PATCH 2/3] core: respect ODR for services_discovery_sys_t

[Romain Vimont]

On Mon, Apr 23, 2018 at 01:43:55PM +0200, Marvin Scholz wrote:
> On 22 Apr 2018, at 17:03, Romain Vimont wrote:
> 
> > See #17078 and #18033
> > ---
> >  include/vlc_common.h                   |  1 -
> >  include/vlc_services_discovery.h       |  2 +-
> >  modules/access/dsm/sd.c                |  4 +--
> >  modules/lua/services_discovery.c       |  4 +--
> >  modules/services_discovery/avahi.c     |  4 +--
> >  modules/services_discovery/mediadirs.c |  4 +--
> >  modules/services_discovery/microdns.c  | 25 +++++++++------
> >  modules/services_discovery/mtp.c       | 43 ++++++++++++++------------
> >  modules/services_discovery/podcast.c   | 16 +++++-----
> >  modules/services_discovery/pulse.c     |  4 +--
> >  modules/services_discovery/sap.c       | 37 ++++++++++++----------
> >  modules/services_discovery/udev.c      |  4 +--
> >  modules/services_discovery/upnp.cpp    |  6 ++--
> >  modules/services_discovery/xcb_apps.c  |  4 +--
> >  14 files changed, 86 insertions(+), 72 deletions(-)
> 
> I think you forgot to change modules/services_discovery/bonjour.m

Wow, thank you for your vigilance :)

However, I don't speak this language, and I don't know what should be
done: local typedefs like for C modules, something similar to namespaces
like for C++?