[vlc-devel] [PATCH 3/3] core: respect ODR for access_sys_t

[Jean-Baptiste Kempf]

On Tue, 24 Apr 2018, at 11:53, Steve Lhomme wrote:
> Le 24/04/2018 à 11:23, Romain Vimont a écrit :
>
>> On Mon, Apr 23, 2018 at 03:40:00PM +0300, Rémi Denis-Courmont wrote:
>>
>>> And I would separate patches converting to void, from namespacing
>>> patches.
>>>
>> You're right. I just did that.
>>> 
> What I don't understand is if the problem is only for C++ why do we
> force a void* on C parts of the code as well.> 
>  Can't we just #ifdef __cplusplus these changes ? And keep the
>  xxx_sys_t for C ?
Technically, we could, but I don't think it is a good idea. Too messy.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734
 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180424/3187755b/attachment.html>