[vlc-devel] [PATCH 3/3] core: respect ODR for access_sys_t

[Romain Vimont]

On Tue, Apr 24, 2018 at 11:59:57AM +0200, Marvin Scholz wrote:
> 
> 
> On 24 Apr 2018, at 11:56, Jean-Baptiste Kempf wrote:
> 
> > On Tue, 24 Apr 2018, at 11:53, Steve Lhomme wrote:
> >> Le 24/04/2018 à 11:23, Romain Vimont a écrit :
> >>
> >>> On Mon, Apr 23, 2018 at 03:40:00PM +0300, Rémi Denis-Courmont wrote:
> >>>
> >>>> And I would separate patches converting to void, from namespacing
> >>>> patches.
> >>>>
> >>> You're right. I just did that.
> >>>>
> >> What I don't understand is if the problem is only for C++ why do we
> >> force a void* on C parts of the code as well.>
> >>  Can't we just #ifdef __cplusplus these changes ? And keep the
> >>  xxx_sys_t for C ?

It also works, and the diff is much smaller :)

> > Technically, we could, but I don't think it is a good idea. Too messy.

+1

> IMO it being void* is better as it allows to simplify things in some cases,
> if not forced to use a struct.

Besides, sometimes the xxx_sys_t* receives a pointer to another type,
violently casted to make the compiler happy (for exemple, in
modules/access/imem.c:OpenAccess()).

(this is not a real argument though, we could fix these specific cases
and keep xxx_sys_t for C modules)

> And just using void* in a specific case (C++) would be very confusing.

+1

> 
> >
> > -- 
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel