[vlc-devel] [PATCH 3/3] core: respect ODR for access_sys_t

[Rémi Denis-Courmont]

Le 24 avril 2018 12:53:45 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>Le 24/04/2018 à 11:23, Romain Vimont a écrit :
>> On Mon, Apr 23, 2018 at 03:40:00PM +0300, Rémi Denis-Courmont wrote:
>>> And I would separate patches converting to void, from namespacing
>patches.
>> You're right. I just did that.
>
>What I don't understand is if the problem is only for C++ why do we 
>force a void* on C parts of the code as well.
>
>Can't we just #ifdef__cplusplus these changes ? And keep the xxx_sys_t 
>for C ?

A struct pointer cannot alias a void pointer in either C or C++. So that would not work even if it would no longer violate ODR.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.