[vlc-devel] [PATCH] contrib/{ebml, matroska}: ensure to build PIC libraries

[Steve Lhomme]

LGTM


Le 25/04/2018 à 01:50, Sean McGovern a écrit :
> ---
>   contrib/src/ebml/rules.mak     | 2 +-
>   contrib/src/matroska/rules.mak | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/src/ebml/rules.mak b/contrib/src/ebml/rules.mak
> index 6c4eb7d..4113668 100644
> --- a/contrib/src/ebml/rules.mak
> +++ b/contrib/src/ebml/rules.mak
> @@ -25,6 +25,6 @@ EBML_EXTRA_FLAGS += CPPFLAGS=""
>   endif
>   
>   .ebml: ebml toolchain.cmake
> -	cd $< && $(HOSTVARS) $(CMAKE) -DBUILD_SHARED_LIBS=OFF
> +	cd $< && $(HOSTVARS_PIC) $(CMAKE) -DBUILD_SHARED_LIBS=OFF
>   	cd $< && $(MAKE) install
>   	touch $@
> diff --git a/contrib/src/matroska/rules.mak b/contrib/src/matroska/rules.mak
> index 1fd3ac9..6c2b209 100644
> --- a/contrib/src/matroska/rules.mak
> +++ b/contrib/src/matroska/rules.mak
> @@ -24,6 +24,6 @@ libmatroska: libmatroska-$(MATROSKA_VERSION).tar.xz .sum-matroska
>   MATROSKA_EXTRA_FLAGS = CXXFLAGS="${CXXFLAGS} -fvisibility=hidden"
>   
>   .matroska: libmatroska toolchain.cmake
> -	cd $< && $(HOSTVARS) $(CMAKE) -DBUILD_SHARED_LIBS=OFF
> +	cd $< && $(HOSTVARS_PIC) $(CMAKE) -DBUILD_SHARED_LIBS=OFF
>   	cd $< && $(MAKE) install
>   	touch $@