[vlc-devel] [vlc-commits] d3d11: Add a missing "extern" for a variable declaration

Rémi Denis-Courmont remi at remlab.net
Sat Aug 4 07:35:23 CEST 2018


Le perjantaina 3. elokuuta 2018, 23.14.33 EEST Martin Storsjö a écrit :
> vlc | branch: master | Martin Storsjö <martin at martin.st> | Fri Aug  3
> 23:13:10 2018 +0300| [c455866ff0c0113de4ee02bacece73b2f9938143] |
> committer: Martin Storsjö
> 
> d3d11: Add a missing "extern" for a variable declaration
> 
> If the "extern" is skipped, the declaration turns into a definition
> of uninitialized data,

Err no. ISO C requires that statically allocated variables are always 
initialized, unlike automatic ones. By default, initialization is zero. In 
these specific cases, the pointers were NULL.

(The patch itself is probably valid though.)

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list