[vlc-devel] [RFC PATCH 1/2] include: add VLC_JNI_VERSION

[Zhao Zhili]

> On Aug 8, 2018, at 9:06 PM, Thomas Guillem <thomas at gllm.fr> wrote:
> 
> Not sure it it worth it to add a new define in vlc_common.h for that.

Since there are only two source files reference the jni version,
it doesn't add much benefit to vlc itself. However, a macro makes
it easier to set a jni version for a whole project (e.g., vlc-android).

> 
> On Thu, Aug 2, 2018, at 08:20, Zhao Zhili wrote:
>> ---
>> include/vlc_common.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>> 
>> diff --git a/include/vlc_common.h b/include/vlc_common.h
>> index c88503c..7e460be 100644
>> --- a/include/vlc_common.h
>> +++ b/include/vlc_common.h
>> @@ -518,6 +518,12 @@ typedef int ( * vlc_list_callback_t ) 
>> ( vlc_object_t *,      /* variable's objec
>> #   include <os2.h>
>> #endif
>> 
>> +#if defined(__ANDROID__)
>> +#   ifndef VLC_JNI_VERSION
>> +#       define VLC_JNI_VERSION JNI_VERSION_1_2
>> +#   endif
>> +#endif
>> +
>> #include "vlc_tick.h"
>> #include "vlc_threads.h"
>> 
>> -- 
>> 2.9.5
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel