[vlc-devel] [PATCH] hxx_sei: Fix improper counting of remaining bytes due to 3-byte emulation

[Devin Heitmueller]

Hi Francois,

> On Aug 16, 2018, at 9:28 AM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> 
> I'm changing the vlc_bits on master to take accounting of pos &
> remaining bytes for custom byte forwarders.
> Fails for now :/

That’s probably the right approach for the long term, but it seems pretty invasive and likely couldn’t be back ported to VLC3 without risking breakage in other areas.

Could we perhaps get this patch merged so it can be backported to stable, and if you decide to refactor a bunch of stuff in vlc_bits.h in master then we would no longer need this patch and it can be backed out?

Fixing the problem in master for some eventual release of VLC4 is great, but not being able to play streams from a very popular commercial encoder in the current shipping version of VLC is problematic.

Devin

---
Devin Heitmueller - LTN Global Communications
dheitmueller at ltnglobal.com