[vlc-devel] [PATCH 05/14] preparser: provide events in callbacks
rom1v at videolabs.io
Thu Aug 16 21:58:14 CEST 2018
Thank you for your review.
On Thu, Aug 16, 2018 at 09:57:58PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 16. elokuuta 2018, 17.02.02 EEST Romain Vimont a écrit :
> > The input thread used by the preparser is not exposed to the caller.
> > Add a "callbacks" parameter to receive preparsing events.
> Shouldn't there be only one void pointer opaque data per preparser?
> It looks rather strange and unusual here.
vlc_MetadataRequest() uses exactly one preparser (the one in
libvlc_priv_t) for all requests.
Every request may want to receive callbacks with different user data
(e.g. playlist/item.c passes a playlist_t* as user data while
lib/media.c passes a libvlc_media_t*).
More information about the vlc-devel