[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

[Thomas Guillem]

On Fri, Aug 17, 2018, at 13:13, Francois Cartegnie wrote:
> Le 17/08/2018 à 09:28, Thomas Guillem a écrit :
> > Since there are always the same value:
> > 
> > `es->i_id = es->fmt.i_id;`
> > ---
> 
> es_fmt can be updated,
> so any link by reference to fmt id gets broken.

es->fmt can only be updated from the ES_OUT_SET_ES_FMT control (yes, when we update the new decoder fmt, we don't touch es->fmt).
We should enforce the new fmt.i_id is the same than the previous one from that control:


        if( es == NULL || es->fmt.i_cat != p_fmt->i_cat || es->fmt.i_id != p_fmt->i_id )
            return VLC_EGENERIC;


> 
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel