[vlc-devel] [PATCH 5/7] video_output: lock the writing of the vout display object

[Rémi Denis-Courmont]

That "access" is internal to the vd core/plugin interface, and supposed to be synchronised by the vd core. In other words, that's irrelevant.

And I'm not even sure it's correct. Mouse events are supposed to go via window, not display.

Le 17 août 2018 14:35:08 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>No it's not, see patch 6/7.
>
>
>Here's an access to display.vd from the Event thread:
>
>
>1  vout_SendDisplayEventMouse       display.c          1347
>0x7ff8337b046e
>2  VoutDisplayEventMouse            display.c          534
>0x7ff8337adc62
>3  VoutDisplayEvent                 display.c          547
>0x7ff8337add09
>4  vout_display_SendEvent           vlc_vout_display.h 316
>0x7ff8220f9e17
>5  vout_display_SendEventMouseMoved vlc_vout_display.h 359
>0x7ff8220f9edd
>6  EventThread                      events.c           258
>0x7ff8220fa5b0
>7  vlc_entry                        thread.c           459
>0x7ff8337f5f72
>
>
>On 17/08/2018 12:49, Rémi Denis-Courmont wrote:
>> The content of vd is still read/write-exclusive for the vout thread. 
>> This locks solves nothing.
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
>> excuser ma brièveté.
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180817/e766b9e6/attachment.html>