[vlc-devel] [PATCH] libvlc: help debug object references remaining in debug builds

[Rémi Denis-Courmont]

Before, there was a pointer to the first child, to the previous sibling and to the next sibling. And offsetting was necessary because of public/private structures.

Now, the same pointers (+ last child) and still some offsetting. Same thing.

And unless the leaf leaked object was an interface, I don't see why you cannot use the dialog or RC command.

Le 17 août 2018 14:39:13 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 17/08/2018 13:26, Rémi Denis-Courmont wrote:
>> Before you had to cast and offset the pointers. And now you have to 
>> cast and offset the pointers. It's the same tedious process.
>
>No, before I had a simple list with a proper to to iterate into. Now I 
>had to figure out what children and siblings and how to get something 
>out of it. I managed to get it in the end but not without some help.
>The 
>current code is very cryptic.
>
>>
>> And it does not take one hour to open the objects tree dialog.
>
>I'm not sure if you are serious. The leak detection happens when libvlc
>
>is destroyed at which point the UI is long gone.
>
>>
>> Le 17 août 2018 09:41:55 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a
>
>> écrit :
>>
>>     On 16/08/2018 18:45, Rémi Denis-Courmont wrote:
>>
>>         Le torstaina 16. elokuuta 2018, 18.20.07 EEST Steve Lhomme a
>>         écrit :
>>
>>             Now with vlc_list 
>>
>>         It is tedious in debugger due to offset LIKE BEFORE. 
>>
>>
>>     No, before we could follow internals->first in the debugger. Now
>it's
>>     hidden in an opaque list with no type and hidden behind macros.
>>
>>         It is trivial in self debugging LIKE BEFORE. In other words,
>>         vlc_list makes literaly no difference.
>>
>>             it's impossible to see anything with the debugger. 
>>
>>         You cannot be serious. 
>>
>>
>>     I spent one hour trying to decypher the API and how it should be
>used, I
>>     never manage to produce anything out of internals->children. Let
>alone
>>     internals->siblings which just had garbage in it. I tried
>>     vlc_list_foreach(), vlc_list_first_entry_or_null() no luck.
>>
>>     It took me 5 minutes to undo this commit and find my leak.
>>
>>         -- Реми Дёни-Курмон http://www.remlab.net/
>>        
>------------------------------------------------------------------------
>>         vlc-devel mailing list To unsubscribe or modify your
>>         subscription options:
>>         https://mailman.videolan.org/listinfo/vlc-devel 
>>
>>
>>    
>------------------------------------------------------------------------
>>
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
>> excuser ma brièveté.
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180817/a9759988/attachment.html>