[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

[Thomas Guillem]

On Fri, Aug 17, 2018, at 15:00, Francois Cartegnie wrote:
> Le 17/08/2018 à 14:43, Thomas Guillem a écrit :
> > Should we identify an ES track with a uint64_t that is always
> > incremented from the es_out ?
> > This will allow to either:
> >  - select a track via the original fmt.i_id (for advanced users via
> >    params/libvlc only, this doesn't prevent es id collision) - select a track with this unique uint64_t id (this will be the id
> >    propagated via input events).
> 
> I don't see why an uint32_t counter would be less prone to overflow than
> uin64_t in our use case

If you end up creating more than 4.2949673E9 ES tracks, I think something is wrong (sample is an exploit?) and the input should be terminated right away.

Could you propose other solutions ?

> 
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel