[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

Rémi Denis-Courmont remi at remlab.net
Fri Aug 17 18:59:22 CEST 2018


I said to keep the ID as meta in the format, so iwe can still match TS ES. But stop using it as track identifier in LibVLC and input interfaces...

If ES is a reference counted object, the pointer itself is intrinsically guaranteed to be temporally unique - even in the racy cases of ES deletion or addition and even across demux slaves.

Le 17 août 2018 15:58:02 GMT+03:00, Francois Cartegnie <fcvlcdev at free.fr> a écrit :
>Le 17/08/2018 à 14:19, Rémi Denis-Courmont a écrit :
>> No it doesn't unless that problem is already there.
>> 
>> You can still remux based on FMT ID. Obviously it won't work if two
>tracks have same ID, but it does not work with the current system
>either.
>
>The issue is collision with slaves and that's exactly the same with
>group id, which is TS program. (and in a similar way the main program
>creation hijacking)
>
>That's still the point of reworking es out and namespace/identify es
>per
>input. There's no reason not to remove the program/es id information,
>unless you want to drop support for mpeg TS and sout.
>
>-- 
>Francois Cartegnie
>VideoLAN - VLC Developer
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180817/f8aa7c9d/attachment.html>


More information about the vlc-devel mailing list