[vlc-devel] [PATCH] add IMM4 decoder

Paul B Mahol onemda at gmail.com
Wed Aug 22 20:04:40 CEST 2018


On 8/22/18, Marvin Scholz <epirat07 at gmail.com> wrote:
>
>
> On 22 Aug 2018, at 19:26, Paul B Mahol wrote:
>
>> On 8/22/18, robux4 at ycbcr.xyz <robux4 at ycbcr.xyz> wrote:
>>> Because the fourcc could be used even if the other patch was reverted.
>>> On 22 Aug 2018 at 17:34 +0200, Paul B Mahol <onemda at gmail.com>, wrote:
>>>> On 8/22/18, Steve Lhomme <robux4 at ycbcr.xyz> wrote:
>>>>> Hi,
>>>>>
>>>>>
>>>>> You should split the commit in 2. One that has the new VLC FourCC and
>>>>> one that adds the lavc mapping.
>>>>
>>>> Why? I never did that before.
>> Please state which commit should change which file and how many
>> patches one must do.
>
> If I understand correctly, you should put the changes in
> include/vlc_fourcc.h and src/misc/fourcc_list.h into one commit.
> And the changes to NEWS and modules/codec/avcodec/fourcc.c into
> another commit.

It this correct, Steve?


More information about the vlc-devel mailing list