[vlc-devel] [PATCH 2/4] vgl: don't call cleanup callback if nothing has done

Thomas Guillem thomas at gllm.fr
Thu Aug 23 10:52:26 CEST 2018


I agree, then you can remove the goto. Pierre ?

On Thu, Aug 23, 2018, at 10:42, Zhao Zhili wrote:
> ---
>  modules/video_output/vgl.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/modules/video_output/vgl.c b/modules/video_output/vgl.c
> index 6af8c67..24caf58 100644
> --- a/modules/video_output/vgl.c
> +++ b/modules/video_output/vgl.c
> @@ -137,7 +137,6 @@ static int Open(vlc_object_t *object)
>      return VLC_SUCCESS;
>  
>  error:
> -    Close(object);
>      return VLC_EGENERIC;
>  }
>  
> -- 
> 2.9.5
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list