[vlc-devel] [PATCH 1/3] Add libcineform to the contribs

[Steve Lhomme]

OK then. Thanks for the clarification.


On 28/08/2018 18:04, Emeric Grange wrote:
> Le mar. 28 août 2018 à 17:12, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>> Couldn't we use the official repo with some patches on top ?
> I mean, sure, you could. I tried that last time, but the SDK (and so
> the patches on top of it) where full of white space trailling that
> where causing patching to fail and I got yelled at here. So I tried
> submitting my patches upstream but they where modified before commit
> and so rendered useless. And there were more whitespaces introduced ^^
> That was just for the linux and macOS build system, pretty basic
> patches. The mingw-w64 compatibility patches are way more
> significant...
>
>> Are there stable releases of the official lib ?
> The SDK is more of a code drop than anything else. It won't move much
> because of backward compatibility with older softwares / older files
> produced many years ago.
>
> Last year we devised a plan at GoPro, with the codec creator, to do a
> spin off of the SDK, a simplier decoding/encoding "only" library, with
> a LOT of stuff removed.
> Things like color conversion and scaling, better left to other
> projects. CineForm "active metadatas" support removed (legacy and
> completely undocumented), "on disk metadatas" (on windows registery
> and macOS plists, I mean...) as well as many other stuff.
> But things didn't really worked out and nobody is left working on
> that. So this is my personnal attempt. I'll try to get in touch with
> the original creator to see what I can do to further simplified the
> library, but as long as I keep the same API, what's the harm?
>
>
>> On 28/08/2018 16:23, Emeric Grange wrote:
>>> From: Emeric <emeric.grange at gmail.com>
>>>
>>> ---
>>>    configure.ac                    |  5 +++++
>>>    contrib/src/cineform/SHA512SUMS |  1 +
>>>    contrib/src/cineform/rules.mak  | 23 +++++++++++++++++++++++
>>>    3 files changed, 29 insertions(+)
>>>    create mode 100644 contrib/src/cineform/SHA512SUMS
>>>    create mode 100644 contrib/src/cineform/rules.mak
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 1627c12b79..1422b75f90 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -2642,6 +2642,11 @@ AS_IF([test "${enable_vpx}" != "no"],[
>>>        ])])
>>>    ])
>>>
>>> +dnl
>>> +dnl CineForm plugin
>>> +dnl
>>> +PKG_ENABLE_MODULES_VLC([CINEFORM], [], [libcineform >= 0.1], [CineForm SDK with decoder and encoder], [auto])
>>> +
>>>    dnl
>>>    dnl twolame encoder plugin
>>>    dnl
>>> diff --git a/contrib/src/cineform/SHA512SUMS b/contrib/src/cineform/SHA512SUMS
>>> new file mode 100644
>>> index 0000000000..68ee113356
>>> --- /dev/null
>>> +++ b/contrib/src/cineform/SHA512SUMS
>>> @@ -0,0 +1 @@
>>> +9aac5a14ac3facfebcab58256ffe947e8a5a8f3bf69367202f09367b5eef5232914d943e8bfcef1c37a06c35f9ce16c80cd4c3517f7428cc26811211ff664767  libcineform-0.1.tar.gz
>>> diff --git a/contrib/src/cineform/rules.mak b/contrib/src/cineform/rules.mak
>>> new file mode 100644
>>> index 0000000000..f5392bc816
>>> --- /dev/null
>>> +++ b/contrib/src/cineform/rules.mak
>>> @@ -0,0 +1,23 @@
>>> +# cineform
>>> +
>>> +CINEFORM_VERSION := 0.1
>>> +CINEFORM_URL := $(GITHUB)emericg/libcineform/archive/$(CINEFORM_VERSION).tar.gz
>>> +
>>> +PKGS += cineform
>>> +ifeq ($(call need_pkg,"libcineform"),)
>>> +PKGS_FOUND += cineform
>>> +endif
>>> +
>>> +$(TARBALLS)/libcineform-$(CINEFORM_VERSION).tar.gz:
>>> +     $(call download_pkg,$(CINEFORM_URL),cineform)
>>> +
>>> +.sum-cineform: libcineform-$(CINEFORM_VERSION).tar.gz
>>> +
>>> +cineform: libcineform-$(CINEFORM_VERSION).tar.gz .sum-cineform
>>> +     $(UNPACK)
>>> +     $(MOVE)
>>> +
>>> +.cineform: cineform toolchain.cmake
>>> +     cd $< && $(HOSTVARS_PIC) $(CMAKE) -DBUILD_STATIC_LIBS:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=OFF .
>>> +     cd $< && $(MAKE) install
>>> +     touch $@
>>> --
>>> 2.18.0
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel