[vlc-devel] [vlc-commits] picture: inline and relax picture_Hold()

[Rémi Denis-Courmont]

Le keskiviikkona 12. joulukuuta 2018, 11.09.13 EET Steve Lhomme a écrit :
> On 11/12/2018 18:11, Rémi Denis-Courmont wrote:
> > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Dec 10
> > 23:34:40 2018 +0200| [aae07419ece284a903ad68ca8644916ec686c6b0] |
> > committer: Rémi Denis-Courmont
> > 
> > picture: inline and relax picture_Hold()
> > 
> > Relaxed memory order cannot work with an external function.
> > 
> >> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=aae07419ece284a903
> >> ad68ca8644916ec686c6b0> 
> > ---
> > 
> >   include/vlc_picture.h | 14 ++++++++++----
> >   src/libvlccore.sym    |  1 -
> >   src/misc/picture.c    |  9 ---------
> >   3 files changed, 10 insertions(+), 14 deletions(-)
> > 
> > diff --git a/include/vlc_picture.h b/include/vlc_picture.h
> > index 772bc4fc1d..3629aa4d72 100644
> > --- a/include/vlc_picture.h
> > +++ b/include/vlc_picture.h
> > @@ -32,6 +32,8 @@
> > 
> >   #else
> >   #include <atomic>
> >   using std::atomic_uintptr_t;
> > 
> > +using std::memory_order;
> 
> Why is this one needed ?

Feel free to remove it.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/