[vlc-devel] [PATCH 2/2] avcodec: write the colorimetry parameters after the codec is opened

Rémi Denis-Courmont remi at remlab.net
Thu Dec 13 17:26:16 CET 2018

Le keskiviikkona 12. joulukuuta 2018, 15.58.19 EET Steve Lhomme a écrit :
> So that the container can overwrite values written by the codec. If the
> container contains no info, nothing gets written and we use what avcodec is
> using.

I don't recall that we ever settled how to resolve meta-data conflicts between 
demuxer, packetizer and decoder. Somebody's bug is somebody else's feature, 
and somebody's work-around is somebody else's regression.

From a logical standpoint, this patch looks wrong. The packetizer parameters 
should be input to the decoder, and the decoder should then decide what the 
output parameters are. That is, unless we agree on a reasoned policy to 
systematically favor the demuxer over the decoder.

Rémi Denis-Courmont

More information about the vlc-devel mailing list