[vlc-devel] [PATCH] aarch64: Check for the .arch_extension directive

[Martin Storsjö]

On Fri, 21 Dec 2018, Rémi Denis-Courmont wrote:

> Le perjantaina 21. joulukuuta 2018, 0.12.35 EET Martin Storsjö a écrit :
>> Clang doesn't support this directive for aarch64 at the moment.
>
> We do not work around toolchain bugs.

Well, whether it's a bug or missing feature can be rather subjective. 
Likewise it can be argued whether it is correct to do a test with 
-march=foo and assuming the result of that test carries over to the 
.arch_extension directive.

I'll try to implement it for upcoming versions of llvm in any case.

> That sort of hacks belongs downstream, just like when a similar issue 
> affected some x86 toolchains.

Sure, if you regard it as a hack, yes.

> Also automatically disabling stuff rarely ends well.

Can you elaborate on what is automatically disabled here?

> And to top it all, this breaks the build.

Yes, that seems to be true, sorry about that. Now I've tested it with GCC 
and fixed the trivial bugs in this patch, and now the deinterlace plugin 
builds just as well as before, with GCC 8.

> Rejected.

If that stands, then fine, so be it. I'll post the updated and fixed patch 
in any case, if other downstreams want to carry it meanwhile.

// Martin