[vlc-devel] [RFC] [PATCH] vout/macosx: Remove HiDPI scaling

Marvin Scholz epirat07 at gmail.com
Fri Feb 2 13:08:34 CET 2018

 I could not figure out in which case this is actually necessary.
 Everything seems to work fine without this.

 If this is necessary for something, please let me know, because
 then we need to find a solution for this, as it is currently
 called in a background thread, which is not allowed for
 NSView methods like bounds or convertRectToBacking.

 modules/video_output/macosx.m | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/modules/video_output/macosx.m b/modules/video_output/macosx.m
index 50dc4b68df..d92bfc3cd3 100644
--- a/modules/video_output/macosx.m
+++ b/modules/video_output/macosx.m
@@ -377,10 +377,6 @@ static int Control (vout_display_t *vd, int query, va_list ap)
                 /* we always use our current frame here, because we have some size constraints
                  in the ui vout provider */
                 vout_display_cfg_t cfg_tmp = *cfg;
-                /* on HiDPI displays, the point bounds don't equal the actual pixel based bounds */
-                NSRect bounds = [sys->glView convertRectToBacking:[sys->glView bounds]];
-                cfg_tmp.display.width = bounds.size.width;
-                cfg_tmp.display.height = bounds.size.height;
                 /* Reverse vertical alignment as the GL tex are Y inverted */
                 if (cfg_tmp.align.vertical == VOUT_DISPLAY_ALIGN_TOP)
2.14.3 (Apple Git-98)

More information about the vlc-devel mailing list