[vlc-devel] [RFC PATCH] macosx: renderer: fix NoneItem not disabled

Thomas Guillem thomas at gllm.fr
Tue Feb 6 16:34:56 CET 2018


It should be disabled by [_selectedItem setState:NSOffState] but it's not case.

Maybe because awakeFromNib() is not called ?
---
 modules/gui/macosx/VLCRendererMenuController.m | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/macosx/VLCRendererMenuController.m b/modules/gui/macosx/VLCRendererMenuController.m
index 16514122f6..2650651017 100644
--- a/modules/gui/macosx/VLCRendererMenuController.m
+++ b/modules/gui/macosx/VLCRendererMenuController.m
@@ -153,6 +153,8 @@
 
 - (void)selectRenderer:(NSMenuItem *)sender
 {
+    [_rendererNoneItem setState:NSOffState];
+
     [_selectedItem setState:NSOffState];
     [sender setState:NSOnState];
     _selectedItem = sender;
-- 
2.11.0



More information about the vlc-devel mailing list