[vlc-devel] [PATCH] opengl: update for libplacebo v0.4.0 API changes

Thomas Guillem thomas at gllm.fr
Mon Feb 12 15:41:43 CET 2018


On Mon, Feb 12, 2018, at 15:32, Niklas Haas wrote:
> Oh, I just realized, we should probably also bump up the minimum
> required version in `configure.ac` to v0.4.0.

Yes, update configure.ac, contribs and test compilation on every platforms.

This won't be backported to 3.0

> 
> On Mon, 12 Feb 2018 15:29:39 +0100, Niklas Haas <vlc at haasn.xyz> wrote:
> > From: Niklas Haas <git at haasn.xyz>
> > 
> > The ra_ prefix was changed to pl_ for consistency.
> > ---
> >  modules/video_output/opengl/fragment_shaders.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/modules/video_output/opengl/fragment_shaders.c b/modules/video_output/opengl/fragment_shaders.c
> > index f959d9a69c..b2659b36eb 100644
> > --- a/modules/video_output/opengl/fragment_shaders.c
> > +++ b/modules/video_output/opengl/fragment_shaders.c
> > @@ -399,10 +399,10 @@ tc_base_prepare_shader(const opengl_tex_converter_t *tc,
> >              continue;
> >  
> >          struct pl_shader_var sv = res->variables[i];
> > -        struct ra_var var = sv.var;
> > +        struct pl_var var = sv.var;
> >  
> >          // libplacebo doesn't need anything else anyway
> > -        if (var.type != RA_VAR_FLOAT)
> > +        if (var.type != PL_VAR_FLOAT)
> >              continue;
> >          if (var.dim_m > 1 && var.dim_m != var.dim_v)
> >              continue;
> > @@ -657,7 +657,7 @@ opengl_fragment_shader_init_impl(opengl_tex_converter_t *tc, GLenum tex_target,
> >          tc->uloc.pl_vars = calloc(res->num_variables, sizeof(GLint));
> >          for (int i = 0; i < res->num_variables; i++) {
> >              struct pl_shader_var sv = res->variables[i];
> > -            ADDF("uniform %s %s;\n", ra_var_glsl_type_name(sv.var), sv.var.name);
> > +            ADDF("uniform %s %s;\n", pl_var_glsl_type_name(sv.var), sv.var.name);
> >          }
> >  
> >          // We can't handle these yet, but nothing we use requires them, either
> > -- 
> > 2.16.1
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list