[vlc-devel] [PATCH 0/3] Fixing input/decoder/sout deadlock with chromecast

Rémi Denis-Courmont remi at remlab.net
Mon Feb 12 21:03:49 CET 2018

Le maanantaina 12. helmikuuta 2018, 21.39.13 EET Thomas Guillem a écrit :
> On Mon, Feb 12, 2018, at 19:13, Rémi Denis-Courmont wrote:
> > Le maanantaina 12. helmikuuta 2018, 19.13.23 EET Thomas Guillem a écrit :
> > > Hello,
> > > 
> > > A lot of users report that Chromecast is not working for their
> > > configuration. Indeed, some Chromecast devices need to be feed with one
> > > minute of data. Since VLC is buffering 300ms of data by default, you'll
> > > have to wait 59.7 sec to start playback on some chromecast devices.
> > 
> > On the one hand, that is a total non-issue if the input is not pacing, as
> > VLC will happily fill the pipeline as fast as the output allows. On the
> > other hand, it is fundamentally unfixable if the input is paced since you
> > can go one minute into the future.
> > 
> > So I utterly fail the point in hacking the decoder and stream output.
> > 
> > And hacking the decoder thread in 3.0, not even funny. It is called
> > "stable" branch for a reason.
> That is the only proper way I found to fix an issue that will touch every
> chromecast users.

This has ALL the flags of a patch that must not be merged to a stable branch:
- It is rushed.
- It is badly designed.
- It affects a central piece of code.
- It is invasive.
- It has no proper tests, and affects a piece of code without proper tests.
- It comes not only after the freeze, but even after the release.
Except for one:
- It does not change the source and binary interfaces.

Merging that code is making a joke of the release process, a joke of 
developers who abide by code freeze, and a joke of the hundres of millions of 
users who don't care for (or already gave up on) Chromecast support.

As if it was not bad enough, there is no credible plan for ongoing support 
here. Because of the current state and nature of the modified component, the 
decoder thread:
- We will not be able to attribute bugs to this patch or to whatever else. So 
we will not know whether to revert or not.
- We will also not be able to backport fixes because they are also impossible 
to test, and the code base will drift too much too soon anyway.

3.0 backports shall be contained to their own code scope. Applies for 
Chromecast, as to anything else.


More information about the vlc-devel mailing list