[vlc-devel] [PATCH 0/3] Fixing input/decoder/sout deadlock with chromecast

[Thomas Guillem]

On Mon, Feb 12, 2018, at 21:26, Rémi Denis-Courmont wrote:
> Le maanantaina 12. helmikuuta 2018, 21.45.12 EET Thomas Guillem a écrit :
> > Furthermore, this is the first release in 3 years. So maybe we missed some
> > major issues that will be visible now. And maybe we'll have to  do some
> > heavy changes to fix them.
> 
> That is precisely why this cannot go in. Did you already forget how pausing 
> audio is badly broken in 2.2.x and we were never able to backport the decoder 
> thread fixes for that? And that is not the only decoder bug fixed in 3.0.

I didn't forget, I never knew, I was not involved in VLC dev at that time

> 
> Any further heavy fixes to the input code are not going to be safe to 
> backport, whether it relates to fixing Chromecast, fixing side effects on 
> Chromecast, or fixing something unrelated.

Finally the PTS_DELAY hack is a bad idea. If just moved the BIG Fifo from the chromecast sout to the DecoderThread. Playing with ACCESS_OUT_CONTROLS_PACE from the chromecast access_output is way better.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel