[vlc-devel] [PATCH] win32/netconf: detect proxy URL from system configuration

[Jean-Baptiste Kempf]

Hello,

On Mon, 12 Feb 2018, at 18:34, Pierre Lamot wrote:
> > > +char *vlc_getProxyUrl(const char *psz_url)
> > > +{
> > > +    char *proxy = config_GetPsz( (vlc_object_t *)(NULL), "http-proxy" );
> > > +    if (proxy != NULL)
> > > +    {
> > 
> > Hmm no. On 4.0 upgrade, users who set a single proxy for lack of better
> > option, will still end up using the single proxy instead of the more
> > flexible Windows setting.
> > 
> 
> I see this the other way around, users who set explicilty a proxy in the  
> preference will expect it to be used over de sytem one.

On Windows, the standard is this one, for most applications:
Have 3 state radiobox
- none
- system
- configured in the application

AIMP, Firefox, Foobar are all doing it like that...

It's not nice, but this is the only way so that people will be happy.



-- 
Jean-Baptiste Kempf -  President
+33 672 704 734