[vlc-devel] [PATCH 0/1] Improve SFTP network performance with buffer

[Rémi Denis-Courmont]

Le mercredi 14 février 2018, 21:24:56 EET Martin Disch a écrit :
> > The prefetch buffer is already 16 MiB by default. So adding a 1 MiB buffer
> > in front of it is not going to do much good.
> 
> That seems logical, but I'm still surprised by the fact that my 1 MiB
> buffer hack makes such a difference (without using prefetch, that is).
> But now that I figured out how to configure the prefetch filter to
> give me the same result, that's a much better solution than
> complicating the SFTP module.

The slowness is logical if the SFTP module (mis)uses the read size as the 
buffer/window size. Compare to HTTP2, which uses a 64 KiB window regardless of 
the read size, or TLS where the frame size is imposed by the server (so the 
client cannot f*ck it up).

-- 
Rémi Denis-Courmont