[vlc-devel] [RFC 2/7] opengl: support rendering subpictures in display dimensions

[Rémi Denis-Courmont]

Le maanantaina 19. helmikuuta 2018, 12.43.05 EET Salah-Eddin Shaban a écrit :
> diff --git a/modules/video_output/opengl/vout_helper.h
> b/modules/video_output/opengl/vout_helper.h index bd4126c632..7cff4a2dfd
> 100644
> --- a/modules/video_output/opengl/vout_helper.h
> +++ b/modules/video_output/opengl/vout_helper.h
> @@ -231,6 +231,6 @@ void vout_display_opengl_Viewport(vout_display_opengl_t
> *vgl, int x, int y, int vout_display_opengl_Prepare(vout_display_opengl_t
> *vgl,
>                                  picture_t *picture, subpicture_t
> *subpicture); int vout_display_opengl_Display(vout_display_opengl_t *vgl,
> -                                const video_format_t *source);
> +                                const vout_display_t *vd);

This exposes much more than necessary to generic helper functions.
Bad idea IMO.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/