[vlc-devel] [vlc-commits] mmdevice: fix opening of invalid device

Rémi Denis-Courmont remi at remlab.net
Tue Feb 20 18:13:36 CET 2018

Le perjantaina 9. helmikuuta 2018, 14.42.30 EET Thomas Guillem a écrit :
> vlc/vlc-3.0 | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Feb  9
> 13:29:29 2018 +0100| [3475766f7a58bd7d28402d7184e5110e1fc8b091] |
> committer: Jean-Baptiste Kempf
> mmdevice: fix opening of invalid device
> CD 6f95511a-91a2-45de-bd43-735bf52a2185
> And check sys->dev locked since it can be written from the MMSession thread.

Of course that cannot happen. sys->dev is only written when the lock is held 
and sys->requested_device is non-NULL. sys->requested_device cannot be non-
NULL at Start(), unless something regressed.

And if sys->dev could change, then you would need to keep the lock all the way 
until Stop(), which is absurd. This cannot be right. Please revert.


More information about the vlc-devel mailing list