[vlc-devel] [PATCH] contrib: qt: Add patches for building with llvm-mingw

[Martin Storsjö]

On Wed, 21 Feb 2018, Hugo Beauzée-Luyssen wrote:

> On Wed, Feb 21, 2018, at 12:59 PM, Martin Storsjö wrote:
>> All of them are backports (in Qt 5.11, everything needed for building
>> with llvm-mingw is upstreamed), with annotations about where they
>> come from.
>> 
>> To actually build with llvm-mingw, one has to use the mkspec
>> win32-clang-g++ instead of win32-g++.
>> ---
>>  ...-limit-command-line-length-when-not-actua.patch |  75 +++++++
>>  ...arfbuzz-Fix-building-for-win64-with-clang.patch |  35 ++++
>>  ...ize-staticMetaObject-with-the-highest-use.patch |  82 ++++++++
>>  .../0007-Only-define-QT_FASTCALL-on-x86_32.patch   |  36 ++++
>>  ...xman-drawhelpers-on-windows-just-like-on-.patch |  39 ++++
>>  ...-a-win32-clang-g-mkspec-for-clang-targeti.patch | 233 ++++++++++++++
>> +++++++
>>  contrib/src/qt/rules.mak                           |   6 +
>>  7 files changed, 506 insertions(+)
>>  create mode 100644 contrib/src/qt/0004-qmake-don-t-limit-command-line-
>> length-when-not-actua.patch
>>  create mode 100644 contrib/src/qt/0005-harfbuzz-Fix-building-for-win64-
>> with-clang.patch
>>  create mode 100644 contrib/src/qt/0006-moc-Initialize-staticMetaObject-
>> with-the-highest-use.patch
>>  create mode 100644 contrib/src/qt/0007-Only-define-QT_FASTCALL-on-
>> x86_32.patch
>>  create mode 100644 contrib/src/qt/0008-Skip-arm-pixman-drawhelpers-on-
>> windows-just-like-on-.patch
>>  create mode 100644 contrib/src/qt/0009-mkspecs-Add-a-win32-clang-g-
>> mkspec-for-clang-targeti.patch

> I was about to ask if we couldn't use Qt 5.9 instead but it seems some of these patches only made it to 5.11. I suppose the likeliness of those being backported is fairly low?
> And speaking of Qt versions, which version do we plan on using for 4.0? I'm not sure we care for LTS here

Yes, I don't think most of them will be backported to 5.9, I think they 
set the bar a bit higher for that.

>From my PoV, I don't have much of a difference what version you choose, 
it's pretty easy to rebase these ones around to anything between 5.6 and 
5.11. Some of the versions inbetween also require a few other patches for 
other issues that appeared after 5.6; most of them are merged in 5.10.1 
except for the actual mkspec.

So if you want to reduce the amount of patches, 5.10.1 is probably the 
safest bet of the actually released versions, while 5.9 probably also is 
good choice since it's a LTS. I'll leave the choice of version up to 
others, in case there's other issues/incompatibilities with the vlc 
code/usecases.

// Martin